sql: replace deprecated descs.Collection method calls #93570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 13, 2022 23:28
Informs cockroachdb#64089. Release note: None
This gets rid of some deprecated descs.Collection method calls. Informs cockroachdb#64089. Release note: None
This commit replaces usages of that method with calls to GetAllObjectsInSchema. Informs cockroachdb#64089. Release note: None
|
This change is |
ajwerner
approved these changes
Dec 14, 2022
| @@ -69,18 +70,27 @@ type schemaResolver struct { | |||
| // GetObjectNamesAndIDs implements the resolver.SchemaResolver interface. | |||
| func (sr *schemaResolver) GetObjectNamesAndIDs( | |||
There was a problem hiding this comment.
I feel like we've got a terminology problem these days: is a function an object?
By my old definition, it is, but it isn't here.
There was a problem hiding this comment.
It is, but it's also a special kind of object in that unlike other objects we don't expect functions to have a namespace entry.
I completely agree with you in general, btw. Untangling GetObjectNamesAndIDs is going to be its own unit of work focused on the resolver interface, and it's something I want to do this week.
|
Thanks for the review! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
descs: remove GetObjectNamesAndIDs method
This commit replaces usages of that method with calls to
GetAllObjectsInSchema.
Informs #64089.
Release note: None
sql: amortize schema descriptor lookups in vtable generation
This gets rid of some deprecated descs.Collection method calls.
Informs #64089.
Release note: None
scbuild,scdeps: replace deprecated descs.Collection method calls
Informs #64089.
Release note: None